Conversation
- Introduced new error response models: `ErrorRsp`, `ErrorRspAllOfError`, and `ErrorRspAllOfErrorValidation` to standardize error handling across the API. - Added `GenericRsp` model for consistent response structure. - Updated existing models to utilize the new `Paging` model for pagination. - Refactored API endpoints to return `GenericRsp` instead of specific response types, improving flexibility. - Consolidated common definitions into `common.yml` for better organization and maintainability.
- Enhanced UserEntity to include 'updated' and 'updatedMs' attributes for better tracking of user data changes.
- Updated UserEntity to inherit from BaseModel instead of User. - Added new fields: user_id, full_name, status, and explicit_webauthn_id for improved user representation. - Removed outdated fields 'updated' and 'updatedMs' to streamline the model.
- Moved import statements for Pydantic to the top of the UserEntity file to enhance readability and maintainability.
corbadoman
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ErrorRsp,ErrorRspAllOfError, andErrorRspAllOfErrorValidationto standardize error handling across the API.GenericRspmodel for consistent response structure.Pagingmodel for pagination.GenericRspinstead of specific response types, improving flexibility.common.ymlfor better organization and maintainability.